-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement max|min
, maxBy|minBy
and maxByAsync|minByAsync
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests I'll do tomorrow. |
bartelink
reviewed
Dec 22, 2023
bartelink
reviewed
Dec 22, 2023
abelbraaksma
force-pushed
the
implement-max-min-maxby-minby
branch
from
December 22, 2023 14:07
23e9039
to
fdb316a
Compare
This is ready to be merged. |
bartelink
reviewed
Dec 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done; the comments in the assertions are a key ingredient
It's not easy avoiding being cryptic!
abelbraaksma
added
topic: surface area
Adds functions to the public surface area
feature request
New feature or enhancement request
labels
Dec 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature request
New feature or enhancement request
topic: surface area
Adds functions to the public surface area
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the push for good coverage of surface area functions, see #208. This implements
min
,max
,minBy
,maxBy
,minByAsync
andmaxByAsync
. Each of these behave exactly like theirSeq
counterparts:null
inputmin
ormax
of the input by usingIComparable
semantics (i.e.:when 'T: comparison
)The xml doc blibs have been taken from
seq.fs
and modified a bit for readability and applicability toTaskSeq
.The signatures are as follows:
TODO list:
TaskSeq.min
TaskSeq.max
TaskSeq.minBy
TaskSeq.maxBy
TaskSeq.minByAsync
TaskSeq.maxByAsync